[PATCH v3 0/8] Add __alloc_size()

From: Kees Cook
Date: Thu Sep 30 2021 - 18:27:17 EST


Hi Andrew,

This is a refresh of the __alloc_size series you have in -mm
currently. This addresses the issues[1] Linus had with attribute
location and the redundant use of __malloc. These are meant to replace
the following patches:

compiler-attributes-add-__alloc_size-for-better-bounds-checking.patch
compiler-attributes-add-__alloc_size-for-better-bounds-checking-fix.patch
checkpatch-add-__alloc_size-to-known-attribute.patch
slab-clean-up-function-declarations.patch
slab-add-__alloc_size-attributes-for-better-bounds-checking.patch
mm-page_alloc-add-__alloc_size-attributes-for-better-bounds-checking.patch
percpu-add-__alloc_size-attributes-for-better-bounds-checking.patch
mm-vmalloc-add-__alloc_size-attributes-for-better-bounds-checking.patch
rapidio-avoid-bogus-__alloc_size-warning.patch

Thanks!

-Kees

[1] https://lore.kernel.org/mm-commits/CAHk-=wgfbSyW6QYd5rmhSHRoOQ=ZvV+jLn1U8U4nBDgBuaOAjQ@xxxxxxxxxxxxxx/

v3:
- move attribute logic around to better handle GCC's weird behavior
- merge __malloc into the __alloc_size macro (Linus)
- refactor attribute positions (Linus)
v2: https://lore.kernel.org/lkml/20210818214021.2476230-1-keescook@xxxxxxxxxxxx
v1: https://lore.kernel.org/lkml/20210818050841.2226600-1-keescook@xxxxxxxxxxxx

Original cover letter:

GCC and Clang both use the "alloc_size" attribute to assist with bounds
checking around the use of allocation functions. Add the attribute,
adjust the Makefile to silence needless warnings, and add the hints to
the allocators where possible. These changes have been in use for a
while now in GrapheneOS.

Kees Cook (8):
rapidio: Avoid bogus __alloc_size warning
Compiler Attributes: add __alloc_size() for better bounds checking
slab: Clean up function prototypes
slab: Add __alloc_size attributes for better bounds checking
mm/kvmalloc: Add __alloc_size attributes for better bounds checking
mm/vmalloc: Add __alloc_size attributes for better bounds checking
mm/page_alloc: Add __alloc_size attributes for better bounds checking
percpu: Add __alloc_size attributes for better bounds checking

Makefile | 15 ++++
drivers/rapidio/devices/rio_mport_cdev.c | 9 ++-
include/linux/compiler-gcc.h | 8 ++
include/linux/compiler_attributes.h | 10 +++
include/linux/compiler_types.h | 12 +++
include/linux/gfp.h | 4 +-
include/linux/mm.h | 16 ++--
include/linux/percpu.h | 6 +-
include/linux/slab.h | 99 +++++++++++++-----------
include/linux/vmalloc.h | 22 +++---
scripts/checkpatch.pl | 3 +-
11 files changed, 128 insertions(+), 76 deletions(-)

--
2.30.2