Re: [GIT PULL][PATCH v11 0/4] Update to zstd-1.4.10

From: Nick Terrell
Date: Wed Sep 29 2021 - 12:56:26 EST




> On Sep 29, 2021, at 3:06 AM, David Sterba <dsterba@xxxxxxx> wrote:
>
> On Wed, Sep 29, 2021 at 01:30:26AM +0000, Nick Terrell wrote:
>>> On Sep 28, 2021, at 5:22 PM, Tom Seewald <tseewald@xxxxxxxxx> wrote:
>>> Has this been abandoned or will there be future attempts at syncing the
>>> in-kernel zstd with the upstream project?
>>
>> Sorry for the lack of action, but this has not been abandoned. I’ve just been
>> preparing a rebased patch-set last week, so expect to see some action soon.
>> Since we’re not in a merge window, I’m unsure if it is best to send out the
>> updated patches now, or wait until the merge window is open, but I’m about to
>> pose that question to the LKML.
>
> If you send it once merge window is open it's unlikely to be merged. The
> code must be ready before it opens and part of linux-next for a week at
> least if not more.
>
>> This work has been on my back burner, because I’ve been busy with work on
>> Zstd and other projects, and have had a hard time justifying to myself spending
>> too much time on this, since progress has been so slow.
>
> What needs to be done from my POV:
>
> - refresh the patches on top of current mainline, eg. v5.15-rc3
>
> - make sure it compiles and works with current in-kernel users of zstd,
> ie. with btrfs in particular, I can do some tests too
>
> - push the patches to a public branch eg. on k.org or github
>
> - ask for adding the branch to linux-next
>
> - try to get some feedback from people that were objecting in the past,
> and of course gather acks or supportive feedback
>
> - once merge window opens, send a pull request to Linus, write the
> rationale why we want this change and summarize the evolution of the
> patchset and why the full version update is perhaps the way forward

Thanks for the clear explanation, that was very helpful! I’ve already rebased
and re-tested myself. I’ll send out a request asking it to be added to linux-next,
and try to gather feedback/acks on that thread. I’ll prepare the rationale for the
linux-next request, so you all can get a chance to read it.

Thanks,
Nick