Re: [PATCH mlx5-next 6/7] mlx5_vfio_pci: Expose migration commands over mlx5 device

From: Leon Romanovsky
Date: Wed Sep 29 2021 - 01:36:13 EST


On Tue, Sep 28, 2021 at 02:22:30PM -0600, Alex Williamson wrote:
> On Wed, 22 Sep 2021 13:38:55 +0300
> Leon Romanovsky <leon@xxxxxxxxxx> wrote:
>
> > From: Yishai Hadas <yishaih@xxxxxxxxxx>
> >
> > Expose migration commands over the device, it includes: suspend, resume,
> > get vhca id, query/save/load state.
> >
> > As part of this adds the APIs and data structure that are needed to
> > manage the migration data.
> >
> > Signed-off-by: Yishai Hadas <yishaih@xxxxxxxxxx>
> > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx>
> > ---
> > drivers/vfio/pci/mlx5_vfio_pci_cmd.c | 358 +++++++++++++++++++++++++++
> > drivers/vfio/pci/mlx5_vfio_pci_cmd.h | 43 ++++
> > 2 files changed, 401 insertions(+)
> > create mode 100644 drivers/vfio/pci/mlx5_vfio_pci_cmd.c
> > create mode 100644 drivers/vfio/pci/mlx5_vfio_pci_cmd.h
>
> Should we set the precedent of a vendor sub-directory like we have
> elsewhere? Either way I'd like to see a MAINTAINERS file update for the
> new driver. Thanks,

I would like to see subfolders, because all these vendor_xxxx.c filenames
look awful to me.

Thanks

>
> Alex
>