Re: [PATCH v2] mfd: hi6421-spmi-pmic: cleanup drvdata

From: Greg Kroah-Hartman
Date: Tue Sep 28 2021 - 05:09:17 EST


On Tue, Sep 28, 2021 at 08:49:10AM +0100, Lee Jones wrote:
> On Tue, 28 Sep 2021, Greg Kroah-Hartman wrote:
>
> > On Tue, Sep 28, 2021 at 08:58:19AM +0200, Mauro Carvalho Chehab wrote:
> > > There are lots of fields in struct hi6421_spmi_pmic that aren't
> > > used. As a matter of fact, only regmap is needed.
> > >
> > > So, drop the struct as a whole, and just set the regmap as
> > > the drvdata.
> > >
> > > Acked-by: Mark Brown <broonie@xxxxxxxxxx>
> > > Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx>
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
> >
> > As everyone else acked this, any objection for me to just take this in
> > my char-misc tree?
> >
> > Otherwise, whoever else want to take it:
> >
> > Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
> If you do end up taking it, you'll have to convert my Ack.
>
> Although, I'm probably in a better position to take it TBH.
>
> Happy with either. You decide.

You can take it, thanks!

greg k-h