Re: [PATCH v2 03/11] dt-bindings: leds: Document "activity" trigger

From: Daniel Palmer
Date: Mon Sep 27 2021 - 18:49:41 EST


Hi Rob,

On Tue, 28 Sept 2021 at 04:52, Rob Herring <robh@xxxxxxxxxx> wrote:
>
> On Thu, Sep 23, 2021 at 03:54:52PM +0900, Daniel Palmer wrote:
> > The "activity" trigger can be used as the default but it's currently
> > undocumented so validating a devicetree that uses it causes a warning.
>
> It is preferred to use 'function' and LED_FUNCTION_CPU. Is there some
> reason that can't be used?

LED_FUNCTION_CPU seems to be tied to
drivers/leds/trigger/ledtrig-cpu.c which I think serves the same
purpose but does it a slightly different way.
Would adding LED_FUNCTION_ACTIVITY work?

Thanks,

Daniel