Re: [PATCH 01/11] arch: Export cpu_logical_map to modules

From: Rob Herring
Date: Mon Sep 27 2021 - 15:32:28 EST


On Fri, Sep 24, 2021 at 12:06 PM Florian Fainelli <f.fainelli@xxxxxxxxx> wrote:
>
> In order to allow drivers/irqchip/irq-bcm7038-l1.c to be built as a
> module and usable in GKI, export cpu_logical_map or __cpu_logical_map
> towards the modules.

This is the usage:

#ifdef CONFIG_SMP
cpu = intc->cpus[cpu_logical_map(smp_processor_id())];
#else
cpu = intc->cpus[0];
#endif

This is totally broken! cpu_logical_map() takes the logical cpu
number, 0-N, and returns the MPIDR which you then use as an array
index.

Rob