Re: [PATCH v2] kprobes: convert tests to kunit

From: Sven Schnelle
Date: Sat Sep 25 2021 - 02:40:02 EST


Hi Masami,

Masami Hiramatsu <mhiramat@xxxxxxxxxx> writes:

> On Fri, 24 Sep 2021 20:19:20 +0200
> Sven Schnelle <svens@xxxxxxxxxxxxx> wrote:
>
>> kernel test robot <lkp@xxxxxxxxx> writes:
>>
>> > Hi Sven,
>> >
>> > Thank you for the patch! Yet something to improve:
>> >
>> [..]
>> > ia64-linux-ld: kernel/test_kprobes.o: in function `entry_handler':
>> >>> test_kprobes.c:(.text+0x150): undefined reference to `kunit_unary_assert_format'
>> >>> ia64-linux-ld: test_kprobes.c:(.text+0x212): undefined reference to `kunit_do_assertion'
>> > ia64-linux-ld: kernel/test_kprobes.o: in function `return_handler2':
>> >>> test_kprobes.c:(.text+0x2f0): undefined reference to `kunit_binary_assert_format'
>> > ia64-linux-ld: test_kprobes.c:(.text+0x452): undefined reference to `kunit_do_assertion'
>> > ia64-linux-ld: test_kprobes.c:(.text+0x522): undefined reference to `kunit_do_assertion'
>>
>> I missed that kunit can be built as module. I'll fix it an send a v3.
>
> Does this mean we can not use KUnit for the feature which is not exposed to module?

I changed the test_kprobes so that it can be build as a module now. (i
guess you already noticed that when looking at the v3 patch).