[ti:ti-rt-linux-5.10.y 9019/9316] drivers/gpu/drm/drm_atomic_helper.c:3311:35: warning: variable 'new_priv_state' set but not used

From: kernel test robot
Date: Wed Sep 15 2021 - 00:56:47 EST


Hi Benoit,

FYI, the error/warning still remains.

tree: git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-rt-linux-5.10.y
head: 43939f54c26e9885d7f59f18ee97dd76393606f9
commit: e172fed2d657ef79c65241251ff26161a8b3f1c4 [9019/9316] drm/atomic: integrate private objects with suspend/resume helpers
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add ti git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git
git fetch --no-tags ti ti-rt-linux-5.10.y
git checkout e172fed2d657ef79c65241251ff26161a8b3f1c4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=mips

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

drivers/gpu/drm/drm_atomic_helper.c: In function 'drm_atomic_helper_commit_duplicated_state':
>> drivers/gpu/drm/drm_atomic_helper.c:3311:35: warning: variable 'new_priv_state' set but not used [-Wunused-but-set-variable]
3311 | struct drm_private_state *new_priv_state;
| ^~~~~~~~~~~~~~


vim +/new_priv_state +3311 drivers/gpu/drm/drm_atomic_helper.c

3284
3285 /**
3286 * drm_atomic_helper_commit_duplicated_state - commit duplicated state
3287 * @state: duplicated atomic state to commit
3288 * @ctx: pointer to acquire_ctx to use for commit.
3289 *
3290 * The state returned by drm_atomic_helper_duplicate_state() and
3291 * drm_atomic_helper_suspend() is partially invalid, and needs to
3292 * be fixed up before commit.
3293 *
3294 * Returns:
3295 * 0 on success or a negative error code on failure.
3296 *
3297 * See also:
3298 * drm_atomic_helper_suspend()
3299 */
3300 int drm_atomic_helper_commit_duplicated_state(struct drm_atomic_state *state,
3301 struct drm_modeset_acquire_ctx *ctx)
3302 {
3303 int i, ret;
3304 struct drm_plane *plane;
3305 struct drm_plane_state *new_plane_state;
3306 struct drm_connector *connector;
3307 struct drm_connector_state *new_conn_state;
3308 struct drm_crtc *crtc;
3309 struct drm_crtc_state *new_crtc_state;
3310 struct drm_private_obj *privobj;
> 3311 struct drm_private_state *new_priv_state;
3312
3313 state->acquire_ctx = ctx;
3314
3315 for_each_new_plane_in_state(state, plane, new_plane_state, i)
3316 state->planes[i].old_state = plane->state;
3317
3318 for_each_new_private_obj_in_state(state, privobj, new_priv_state, i)
3319 state->private_objs[i].old_state = privobj->state;
3320
3321 for_each_new_crtc_in_state(state, crtc, new_crtc_state, i)
3322 state->crtcs[i].old_state = crtc->state;
3323
3324 for_each_new_connector_in_state(state, connector, new_conn_state, i)
3325 state->connectors[i].old_state = connector->state;
3326
3327 ret = drm_atomic_commit(state);
3328
3329 state->acquire_ctx = NULL;
3330
3331 return ret;
3332 }
3333 EXPORT_SYMBOL(drm_atomic_helper_commit_duplicated_state);
3334

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip