Re: [PATCH v2 1/5] bootconfig: Fix to check the xbc_node is used before free it

[Linus Torvalds]

On Tue, Sep 14, 2021 at 5:53 PM Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
>
> Fix to check the xbc_node is used before calling memblock_free()
> because passing NULL to phys_addr() will cause a panic.

No.

That's the previous bad situation.

The whole point of memblock_free_ptr() is that it actually acts the
way a memory freeing function *should*, and has no problems with NULL
pointers.

>    - Rebase on top of Linus tree.

Please don't do a mindless rebase, take the actual changes into account.

         Linus