Re: [PATCH] regulator: rtq6752: Enclose 'enable' gpio control by enable flag

From: ChiYuan Huang
Date: Tue Sep 14 2021 - 10:11:17 EST


Hi,

Mark Brown <broonie@xxxxxxxxxx> 於 2021年9月14日 週二 下午10:08寫道:
>
> On Tue, Sep 14, 2021 at 09:58:32PM +0800, cy_huang wrote:
> > From: ChiYuan Huang <cy_huang@xxxxxxxxxxx>
> >
> > Fix 'enable' gpio control logic if it's specified.
> >
> > Signed-off-by: ChiYuan Huang <cy_huang@xxxxxxxxxxx>
> > ---
> > This patch is to prevent the logic error from the below cases.
> >
> > 1. All off and both are sequentially controlled to be on.
> > The 'enable' gpio control block to be called twice including the delay time.
> >
> > 2. Both are on and one is preparing to be off.
> > The 'enable' gpio control low before register cache is configured to be true.
>
> This should be in the actual commit message.
OK, I'll send the v2 and add all comments into the commit message.
Thx.