[PATCH v2 3/3] usb: typec: tipd: Remove WARN_ON in tps6598x_block_read

From: Sven Peter
Date: Tue Sep 14 2021 - 10:02:55 EST


Calling tps6598x_block_read with a higher than allowed len can be
handled by just returning an error. There's no need to crash systems
with panic-on-warn enabled.

Signed-off-by: Sven Peter <sven@xxxxxxxxxxxxx>
---
v1 -> v2:
- added this patch to also remove the WARN_ON in tps6598x_block_read
as suggested by greg k-h

drivers/usb/typec/tipd/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
index 8c79ba17a157..93e56291f0cf 100644
--- a/drivers/usb/typec/tipd/core.c
+++ b/drivers/usb/typec/tipd/core.c
@@ -117,7 +117,7 @@ tps6598x_block_read(struct tps6598x *tps, u8 reg, void *val, size_t len)
u8 data[TPS_MAX_LEN + 1];
int ret;

- if (WARN_ON(len + 1 > sizeof(data)))
+ if (len + 1 > sizeof(data))
return -EINVAL;

if (!tps->i2c_protocol)
--
2.25.1