Re: [PATCH] sparc32: Page align size in arch_dma_alloc

From: Christoph Hellwig
Date: Tue Sep 14 2021 - 07:26:52 EST


On Tue, Sep 14, 2021 at 01:16:16PM +0200, Andreas Larsson wrote:
> Before the patch, arch_dma_alloc did via srmmu_mapiorange set up pages with
> SRMMU_PRIV, which is all fine as it sets up kernel buffers. With your patch
> we get PAGE_KERNEL as an argument to dma_pgprot in the corresponding call
> path that earlier lead to arch_dma_alloc. PAGE_KERNEL already includes
> SRMMU_PRIV so adding it again should not be necessary.

You're right, I missed that PAGE_KERNEL already includes SRMMU_PRIV.