Re: [PATCH 07/16] tty: remove file from tty_ldisc_ops::ioctl and compat_ioctl

From: Krzysztof Kozlowski
Date: Tue Sep 14 2021 - 05:16:22 EST


On 14/09/2021 11:11, Jiri Slaby wrote:
> After the previous patches, noone needs 'file' parameter in neither
> ioctl hook from tty_ldisc_ops. So remove 'file' from both of them.
>
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> Cc: Marcel Holtmann <marcel@xxxxxxxxxxxx>
> Cc: Johan Hedberg <johan.hedberg@xxxxxxxxx>
> Cc: Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx>
> Cc: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> Cc: Wolfgang Grandegger <wg@xxxxxxxxxxxxxx>
> Cc: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> Cc: Andreas Koensgen <ajk@xxxxxxxxxxxxxxxxxxxxx>
> Cc: Paul Mackerras <paulus@xxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> ---
> drivers/bluetooth/hci_ldisc.c | 5 ++---
> drivers/input/serio/serport.c | 5 ++---
> drivers/net/can/slcan.c | 4 ++--
> drivers/net/hamradio/6pack.c | 4 ++--
> drivers/net/hamradio/mkiss.c | 4 ++--
> drivers/net/ppp/ppp_async.c | 3 +--
> drivers/net/ppp/ppp_synctty.c | 3 +--
> drivers/net/slip/slip.c | 4 ++--
> drivers/tty/n_gsm.c | 4 ++--
> drivers/tty/n_hdlc.c | 5 ++---
> drivers/tty/n_tty.c | 4 ++--
> drivers/tty/tty_io.c | 8 ++++----
> include/linux/tty_ldisc.h | 15 +++++++--------
> net/nfc/nci/uart.c | 5 ++---
> 14 files changed, 33 insertions(+), 40 deletions(-)
>

For NFC:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>



Best regards,
Krzysztof