Re: [PATCH v2] io-wq: expose IO_WQ_ACCT_* enumeration items to UAPI

From: Eugene Syromiatnikov
Date: Mon Sep 13 2021 - 11:53:05 EST


On Mon, Sep 13, 2021 at 07:28:11AM -0600, Jens Axboe wrote:
> This is really the same thing as before, just the names have changed.
> What I suggested was keeping the enum in io_uring, then just adding
>
> enum {
> IO_WQ_BOUND,
> IO_WQ_UNBOUND,
> };
>
> to uapi header. The ACCT stuff is io-wq specific too, that kind of naming
> shouldn't be propagated to userspace.

My apologies, I've overlooked the fact that the proposed names
are different. Updated and resent[1].

[1] https://lore.kernel.org/lkml/20210913154415.GA12890@xxxxxxxxxxxxxxxxx/

> A BUILD_BUG_ON() could be added for them being different, but honestly
> I don't think that's worth it.