Re: [PATCH linux-next] tee/optee/shm_pool: fix application of sizeof to pointer

From: Jens Wiklander
Date: Mon Sep 13 2021 - 05:21:50 EST


On Thu, Sep 02, 2021 at 11:34:28AM +0100, Daniel Thompson wrote:
> On Thu, Aug 19, 2021 at 08:21:27PM -0700, CGEL wrote:
> > From: jing yangyang <jing.yangyang@xxxxxxxxxx>
> >
> > sizeof when applied to a pointer typed expression gives the size of
> > the pointer.
> >
> > ./drivers/tee/optee/shm_pool.c:38:28-34: ERROR application of sizeof to pointer
> >
> > This issue was detected with the help of Coccinelle.
> >
> > Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> > Signed-off-by: jing yangyang <jing.yangyang@xxxxxxxxxx>
>
> This should not affect code generation since both pages and *pages are
> pointers but the change looks good to me.
>
> Reviewed-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>

Thanks for reviewing, I agree with your analysis.
I'm picking this up as a bugfix for V5.15.

Cheers,
Jens