Re: [PATCH v6] Bluetooth: Keep MSFT ext info throughout a hci_dev's life cycle

From: Marcel Holtmann
Date: Fri Sep 10 2021 - 03:28:08 EST


Hi Manish,

> This splits the msft_do_{open/close} to msft_do_{open/close} and
> msft_{register/unregister}. With this change it is possible to retain
> the MSFT extension info irrespective of controller power on/off state.
> This helps bluetoothd to report correct 'supported features' of the
> controller to the D-Bus clients event if the controller is off. It also
> re-reads the MSFT info upon every msft_do_open().
>
> The following test steps were performed.
> 1. Boot the test device and verify the MSFT support debug log in syslog.
> 2. Power off the controller and read the 'supported features', power on
> and read again.
> 3. Restart the bluetoothd and verify the 'supported features' value.
>
> Signed-off-by: Miao-chen Chou <mcchou@xxxxxxxxxxxx>
> Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@xxxxxxxxxxxx>
> Reviewed-by: Archie Pusaka <apusaka@xxxxxxxxxxxx>
> Reviewed-by: Alain Michaud <alainm@xxxxxxxxxxxx>
> Signed-off-by: Manish Mandlik <mmandlik@xxxxxxxxxx>
> ---
>
> Changes in v6:
> - Split msft_do_{open/close} into msft_do_{open/close} and
> msft_{register/unregister}
>
> Changes in v5:
> - Rebase on ToT and remove extra blank line
>
> Changes in v4:
> - Re-read the MSFT data instead of skipping if it's initiated already
>
> Changes in v3:
> - Remove the accepted commits from the series
>
> net/bluetooth/hci_core.c | 3 +++
> net/bluetooth/msft.c | 55 +++++++++++++++++++++++++++++++++-------
> net/bluetooth/msft.h | 4 +++
> 3 files changed, 53 insertions(+), 9 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel