Re: [EXTERNAL] Re: [EXTERNAL] Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH] net: phy: dp83tc811: modify list of interrupts enabled at initialization

From: Modi, Geet
Date: Thu Sep 09 2021 - 21:42:25 EST


Hi Andrew,

Please be assure the monitors are part of the PHY and well captured in device datasheet. The only reason to go selectively is as we have not carefully reviewed the other interrupts usage by application, hence don't want to make the change in haste.

Regards,
Geet




On 9/9/21, 6:31 PM, "Andrew Lunn" <andrew@xxxxxxx> wrote:

On Fri, Sep 10, 2021 at 12:41:53AM +0000, Modi, Geet wrote:
> Hi Andrew,
>
> As mentioned we want to do this in phases:
> a) this patch to disable the Overvoltage driver interrupt
> b) After carefully considering other interrupts, plan a follow-on patch to take care of other interrupts.

I still don't get it. Why just Over volt now and not the rest, which
are equally useless? It makes me think there is something seriously
wrong with over voltage, which you are not telling us about. Maybe an
interrupt storm? If there is something broken here, this patch needs
to be back ported to stable.

Andrew