Re: [PATCH] sysfs: Remove page boundary align limitation on sysfs_emit and sysfs_emit_at

From: Greg Kroah-Hartman
Date: Wed Sep 08 2021 - 08:32:11 EST


On Wed, Sep 08, 2021 at 08:07:23PM +0800, Lang Yu wrote:
> The key purpose of sysfs_emit and sysfs_emit_at is to
> ensure that no overrun is done. Make them more equivalent
> with scnprintf.

That's not the only purpose.

So why are you changing this?

What in-kernel users are being tripped up by this, shouldn't we fix them
instead?

Remember, sysfs files are "one value per file", so why are the boundries
not properly set here?

thanks,

greg k-h