Re: [PATCH] pwm: ab8500: Don't check the return code of pwmchip_remove()

From: Uwe Kleine-König
Date: Wed Sep 08 2021 - 05:17:41 EST


Hello zhaoxiao,

On Wed, Sep 08, 2021 at 02:02:00PM +0800, zhaoxiao wrote:
> pwmchip_remove() returns always 0. Don't use the value to make it
> possible to eventually change the function to return void. Also the
> driver core ignores the return value of ab8500_pwm_remove()
> and considers the device removed anyhow. So returning early results
> in a resource leak.
>
> Signed-off-by: zhaoxiao <long870912@xxxxxxxxx>

Can you please base your patches on top of linux-next? This patch is
invalid in the presence of
https://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm.git/commit/?h=for-next&id=14ac9e17f9bd4bd0dfe18e384a3c2ca8dfbffcc8

So this is waste of your (and my) time :-\

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |