Re: [PATCH] staging: r8188eu: remove unused function Hal_ProSetCrystalCap()

From: Phillip Potter
Date: Tue Sep 07 2021 - 18:30:08 EST


On Tue, 7 Sept 2021 at 22:09, Michael Straube <straube.linux@xxxxxxxxx> wrote:
>
> Remove unused function Hal_ProSetCrystalCap().
>
> Signed-off-by: Michael Straube <straube.linux@xxxxxxxxx>
> ---
> drivers/staging/r8188eu/core/rtw_mp.c | 9 ---------
> drivers/staging/r8188eu/include/rtw_mp.h | 1 -
> 2 files changed, 10 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/core/rtw_mp.c b/drivers/staging/r8188eu/core/rtw_mp.c
> index dabdd0406f30..82268f754da0 100644
> --- a/drivers/staging/r8188eu/core/rtw_mp.c
> +++ b/drivers/staging/r8188eu/core/rtw_mp.c
> @@ -924,12 +924,3 @@ void _rtw_mp_xmit_priv(struct xmit_priv *pxmitpriv)
> exit:
> ;
> }
> -
> -void Hal_ProSetCrystalCap(struct adapter *pAdapter, u32 CrystalCapVal)
> -{
> - CrystalCapVal = CrystalCapVal & 0x3F;
> -
> - // write 0x24[16:11] = 0x24[22:17] = CrystalCap
> - PHY_SetBBReg(pAdapter, REG_AFE_XTAL_CTRL, 0x7FF800,
> - (CrystalCapVal | (CrystalCapVal << 6)));
> -}
> diff --git a/drivers/staging/r8188eu/include/rtw_mp.h b/drivers/staging/r8188eu/include/rtw_mp.h
> index b2befe09d944..73fb6974d076 100644
> --- a/drivers/staging/r8188eu/include/rtw_mp.h
> +++ b/drivers/staging/r8188eu/include/rtw_mp.h
> @@ -466,7 +466,6 @@ void Hal_TriggerRFThermalMeter(struct adapter *pAdapter);
> u8 Hal_ReadRFThermalMeter(struct adapter *pAdapter);
> void Hal_SetCCKContinuousTx(struct adapter *pAdapter, u8 bStart);
> void Hal_SetOFDMContinuousTx(struct adapter *pAdapter, u8 bStart);
> -void Hal_ProSetCrystalCap (struct adapter *pAdapter , u32 CrystalCapVal);
> void _rtw_mp_xmit_priv(struct xmit_priv *pxmitpriv);
> void MP_PHY_SetRFPathSwitch(struct adapter *pAdapter ,bool bMain);
>
> --
> 2.33.0
>

Looks good Michael, many thanks.

Acked-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx>

Regards,
Phil