Re: [PATCH] mmc: mtk-sd: Remove unused parameters(mrq)

From: Ulf Hansson
Date: Mon Sep 06 2021 - 13:10:41 EST


On Fri, 27 Aug 2021 at 11:39, Chanwoo Lee <cw9316.lee@xxxxxxxxxxx> wrote:
>
> From: ChanWoo Lee <cw9316.lee@xxxxxxxxxxx>
>
> The mmc_request structure(*mrq) is not used. //msdc_cmd_find_resp
> I remove the unnecessary code related to the mmc_request structure.
>
> Signed-off-by: ChanWoo Lee <cw9316.lee@xxxxxxxxxxx>

Queued for v5.16 on the temporary devel branch, thanks!

Kind regards
Uffe


> ---
> drivers/mmc/host/mtk-sd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 4dfc246c5f95..813f57f6d9cc 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -961,7 +961,7 @@ static void msdc_set_mclk(struct msdc_host *host, unsigned char timing, u32 hz)
> }
>
> static inline u32 msdc_cmd_find_resp(struct msdc_host *host,
> - struct mmc_request *mrq, struct mmc_command *cmd)
> + struct mmc_command *cmd)
> {
> u32 resp;
>
> @@ -997,7 +997,7 @@ static inline u32 msdc_cmd_prepare_raw_cmd(struct msdc_host *host,
> * stop << 14 | rw << 13 | dtype << 11 | rsptyp << 7 | brk << 6 | opcode
> */
> u32 opcode = cmd->opcode;
> - u32 resp = msdc_cmd_find_resp(host, mrq, cmd);
> + u32 resp = msdc_cmd_find_resp(host, cmd);
> u32 rawcmd = (opcode & 0x3f) | ((resp & 0x7) << 7);
>
> host->cmd_rsp = resp;
> --
> 2.29.0
>