Re: [PATCH v2 1/2] of: platform: Make sure bus only devices get probed

[Geert Uytterhoeven]

Hi Ulf,

On Fri, Sep 3, 2021 at 11:19 AM Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
> On Fri, 3 Sept 2021 at 01:04, Saravana Kannan <saravanak@xxxxxxxxxx> wrote:
> > fw_devlink could end up creating device links for bus only devices.
> > However, bus only devices don't get probed and can block probe() or
> > sync_state() [1] call backs of other devices. To avoid this, set up
> > these devices to get probed by the simple-pm-bus.
> >
> > [1] - https://lore.kernel.org/lkml/CAPDyKFo9Bxremkb1dDrr4OcXSpE0keVze94Cm=zrkOVxHHxBmQ@xxxxxxxxxxxxxx/
> > Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx>
> > Tested-by: Saravana Kannan <saravanak@xxxxxxxxxx>
>
> Again, this looks like a nice solution to the problem.
>
> One question though. The Kconfig SIMPLE_PM_BUS, should probably be
> "default y" - or something along those lines to make sure fw_devlink
> works as expected.

I would love for SIMPLE_PM_BUS to go away, and all of its functionality
to be usurped by the standard simple-bus handling.

In the modern world, everything uses power management and Runtime
PM, and the distinction between "simple-bus" and "simple-pm-bus"
is purely artificial.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds