[PATCH v8 0/1] asus-wmi: Add support for custom fan curves

From: Luke D. Jones
Date: Tue Aug 31 2021 - 22:51:55 EST


Add support for custom fan curves found on some ASUS ROG laptops.

- V1
+ Initial patch work
- V2
+ Don't fail and remove wmi driver if error from
asus_wmi_evaluate_method_buf() if error is -ENODEV
- V3
+ Store the "default" fan curves
+ Call throttle_thermal_policy_write() if a curve is erased to ensure
that the factory default for a profile is applied again
- V4
+ Do not apply default curves by default. Testers have found that the
default curves don't quite match actual no-curve behaviours
+ Add method to enable/disable curves for each profile
- V5
+ Remove an unrequired function left over from previous iterations
+ Ensure default curves are applied if user writes " " to a curve path
+ Rename "active_fan_curve_profiles" to "enabled_fan_curve_profiles" to
better reflect the behavious of this setting
+ Move throttle_thermal_policy_write_*pu_curves() and rename to
fan_curve_*pu_write()
+ Merge fan_curve_check_valid() and fan_curve_write()
+ Remove some leftover debug statements
- V6
+ Refactor data structs to store array or u8 instead of strings.
This affects the entire patch except the enabled_fan_curves block
+ Use sysfs_match_string in enabled_fan_curve block
+ Add some extra comments to describe things
+ Allow some variation in how fan curve input can be formatted
+ Use SENSOR_DEVICE_ATTR_2_RW() to reduce the amount of lines per
fan+profile combo drastically
- V7
+ Further refactor to use pwm1_auto_point1_temp + pwm1_auto_point1_pwm
format, creating two blocks of attributes for CPU and GPU fans
+ Remove storing of defualt curves and method to reset them. The
factory defaults are still populated in to structs on module load
so users have a starting point
- V8
+ Make asus_wmi_evaluate_method_buf() safe
+ Take in to account machines that do not have throttle_thermal_policy
but do have a single custom fan curve. Thes machines can't use a
throttle_thermal mode change to reset the fans to factory default if
fan curve is disabled so we need to write their stored default back.
+ Formatting tidy and dev_err() use
+ Extra comments to make certain things (such as above) more clear
+ Give generated hwmon a more descriptive `name asus_custom_fan_curve`

Luke D. Jones (1):
asus-wmi: Add support for custom fan curves

drivers/platform/x86/asus-wmi.c | 494 ++++++++++++++++++++-
include/linux/platform_data/x86/asus-wmi.h | 2 +
2 files changed, 492 insertions(+), 4 deletions(-)

--
2.31.1