Re: [PATCH] block/mq-deadline: Move dd_queued() to fix defined but not used warning

From: Bart Van Assche
Date: Mon Aug 30 2021 - 19:22:21 EST


On 8/30/21 2:11 AM, Geert Uytterhoeven wrote:
If CONFIG_BLK_DEBUG_FS=n:

block/mq-deadline.c:274:12: warning: ‘dd_queued’ defined but not used [-Wunused-function]
274 | static u32 dd_queued(struct deadline_data *dd, enum dd_prio prio)
| ^~~~~~~~~

Fix this by moving dd_queued() just before the sole function that calls
it.

Fixes: 7b05bf771084ff78 ("Revert "block/mq-deadline: Prioritize high-priority requests"")
Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

The Fixes tag probably should be changed into the following:

Fixes: 38ba64d12d4c ("block/mq-deadline: Track I/O statistics")

Anyway:

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>