Re: [PATCH] arm: dts: qcom-msm8974: Add xo_board reference clock to DSI0 PHY

[Marijn Suijten]

On 2021-08-30 16:28:15, Bjorn Andersson wrote:
> On Mon 30 Aug 12:57 CDT 2021, Marijn Suijten wrote:
> 
> > According to YAML validation, and for a future patchset putting this
> > xo_board reference clock to use as VCO reference parent, add the missing
> > clock to dsi_phy0.
> > 
> 
> And just to confirm on MSM8974 "ref" is supposed to be 19.2Mhz?

Yes, the 28nm-hpm driver (unlike the 28nm-8960 driver for apq8064) uses
19.2MHz for its hardcoded VCO_REF_CLK_RATE calculations.

Perhaps we should reword the commit message to read "... add the missing
19.2MHz xo clock ...".

- Marijn

> Regards,
> Bjorn
> 
> > Fixes: 5a9fc531f6ec ("ARM: dts: msm8974: add display support")
> > Signed-off-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
> > ---
> >  arch/arm/boot/dts/qcom-msm8974.dtsi | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
> > index db4c06bf7888..96722172b064 100644
> > --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> > +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> > @@ -1580,8 +1580,8 @@ dsi_phy0: dsi-phy@fd922a00 {
> >  				#phy-cells = <0>;
> >  				qcom,dsi-phy-index = <0>;
> >  
> > -				clocks = <&mmcc MDSS_AHB_CLK>;
> > -				clock-names = "iface";
> > +				clocks = <&mmcc MDSS_AHB_CLK>, <&xo_board>;
> > +				clock-names = "iface", "ref";
> >  			};
> >  		};
> >  
> > -- 
> > 2.33.0
> >