RE: [PATCH v2] nvme: update keep alive interval when kato is modified

From: sasaki tatsuya
Date: Mon Aug 30 2021 - 07:28:36 EST


> On 8/25/21 10:53 AM, hch@xxxxxx wrote:
> > Any reason we can't just call this from nvme_passthru_end instead
> > of inventing a new API? Right now the nvmet passthrough code never
> > uses the underlying keep alive code, so it doesn't make a difference,
> > but I expect we'll need more handling for passthrough commands like
> > this, and we might also grow more users (e.g. the io_uring based
> > passthrough).
> >
> Yeah, we'll need that anyway if and when hostid becomes settable.

Thanks for your comments. To call nvme_update_keep_alive from
nvme_passthru_end, I think nvme_passthru_end needs an argument of
a pointer to nvme_command. I will try to call it from nvme_passthru_end.
Please correct me, if I am misunderstanding what you mean.

Thanks.