Re: [PATCH] hwmon: (pmbus/ibm-cffps) Do not swap max_power_out

From: Guenter Roeck
Date: Sat Aug 28 2021 - 11:52:55 EST


On Fri, Aug 27, 2021 at 11:04:33PM +0000, Brandon Wyman wrote:
> The bytes for max_power_out from the ibm-cffps devices do not need to be
> swapped.
>
> Signed-off-by: Brandon Wyman <bjwyman@xxxxxxxxx>

Eddie, can you confirm this ?

Thanks,
Guenter

> ---
> drivers/hwmon/pmbus/ibm-cffps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/pmbus/ibm-cffps.c b/drivers/hwmon/pmbus/ibm-cffps.c
> index df712ce4b164..29b77f192c9e 100644
> --- a/drivers/hwmon/pmbus/ibm-cffps.c
> +++ b/drivers/hwmon/pmbus/ibm-cffps.c
> @@ -171,7 +171,7 @@ static ssize_t ibm_cffps_debugfs_read(struct file *file, char __user *buf,
> cmd = CFFPS_SN_CMD;
> break;
> case CFFPS_DEBUGFS_MAX_POWER_OUT:
> - rc = i2c_smbus_read_word_swapped(psu->client,
> + rc = i2c_smbus_read_word_data(psu->client,
> CFFPS_MAX_POWER_OUT_CMD);
> if (rc < 0)
> return rc;
> --
> 2.25.1
>