Re: [PATCH v1 2/2] mailbox: qcom: Add support for sm4125 sm6115 APCS IPC

From: Iskren Chernev
Date: Sat Aug 28 2021 - 02:22:34 EST




On 8/27/21 6:42 PM, Nicolas Dechesne wrote:
> On Tue, Jun 22, 2021 at 10:38 PM Iskren Chernev
> <iskren.chernev@xxxxxxxxx> wrote:
>>
>> SM4125 and SM6115, codename bengal, have APCS mailbox setup similar to
>> msm8998 and msm8916.
>
> subject and commit refer to SM4125/SM6115, but the diff below is about
> 4250/6115. I suppose it's a typo here, since 6115 is similar to 4250,
> not 4125, right?

Yes, you're correct. The issue was resolved in v2 submitted shorty after:

https://lkml.org/lkml/2021/6/27/167

>>
>> Signed-off-by: Iskren Chernev <iskren.chernev@xxxxxxxxx>
>> ---
>> drivers/mailbox/qcom-apcs-ipc-mailbox.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
>> index f25324d03842..1a4d8cca5881 100644
>> --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
>> +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
>> @@ -166,6 +166,8 @@ static const struct of_device_id qcom_apcs_ipc_of_match[] = {
>> { .compatible = "qcom,sc8180x-apss-shared", .data = &apps_shared_apcs_data },
>> { .compatible = "qcom,sdm660-apcs-hmss-global", .data = &sdm660_apcs_data },
>> { .compatible = "qcom,sdm845-apss-shared", .data = &apps_shared_apcs_data },
>> + { .compatible = "qcom,sm4250-apcs-hmss-global", .data = &sdm660_apcs_data },
>> + { .compatible = "qcom,sm6115-apcs-hmss-global", .data = &sdm660_apcs_data },
>> { .compatible = "qcom,sm8150-apss-shared", .data = &apps_shared_apcs_data },
>> { .compatible = "qcom,sdx55-apcs-gcc", .data = &sdx55_apcs_data },
>> {}
>> --
>> 2.31.1
>>