Re: [PATCH v2 1/3] selftests/sync: Remove the deprecated config SYNC

[Shuah Khan]

On 8/26/21 7:35 PM, lizhijian@xxxxxxxxxxx wrote:
> On 27/08/2021 05:10, Shuah Khan wrote:
> > On 8/25/21 7:58 PM, Li Zhijian wrote:
> > > SYNC was removed since aff9da10e21 ("staging/android: make sync_timeline internal to sw_sync")
> > > LKP/0Day will check if all configs listing under selftests are able to be enabled properly.
> >
> > Can you please state what you arr fxing and also keep the sentences
> > 75 chars or less.
> >
> > Where is LKP warning?
> https://01.org/lkp
> LKP(aka. 0Day) often reports issue related to the *recent* kernel commits/WIP patches publicly.
> As the LKP keeping improvement, it will cover more aspects in the kernel so that more issues will be detected.
>
> So in this case, which is related to too old kernel, it just reported it internally.
>
>
> > Include the warning and explain why this
> > change is necessary.
> - it's not reasonable to keep the deprecated configs, right ?
>
> - In my understanding, configs under kselftests are recommended by corresponding tests.
> So if some configs are missing, it will impact the testing results
>
> Do you mean the commit log should include above 2 reasons ?

Correct. I am asking the commit log to include these details.

thanks,
-- Shuah