Re: [PATCH v2] net: don't unconditionally copy_from_user a struct ifreq for socket ioctls

From: patchwork-bot+netdevbpf
Date: Fri Aug 27 2021 - 04:50:11 EST


Hello:

This patch was applied to netdev/net.git (refs/heads/master):

On Thu, 26 Aug 2021 12:46:01 -0700 you wrote:
> A common implementation of isatty(3) involves calling a ioctl passing
> a dummy struct argument and checking whether the syscall failed --
> bionic and glibc use TCGETS (passing a struct termios), and musl uses
> TIOCGWINSZ (passing a struct winsize). If the FD is a socket, we will
> copy sizeof(struct ifreq) bytes of data from the argument and return
> -EFAULT if that fails. The result is that the isatty implementations
> may return a non-POSIX-compliant value in errno in the case where part
> of the dummy struct argument is inaccessible, as both struct termios
> and struct winsize are smaller than struct ifreq (at least on arm64).
>
> [...]

Here is the summary with links:
- [v2] net: don't unconditionally copy_from_user a struct ifreq for socket ioctls
https://git.kernel.org/netdev/net/c/d0efb16294d1

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html