Re: [PATCH v9 1/8] opp: Add dev_pm_opp_from_clk_rate()

From: kernel test robot
Date: Thu Aug 26 2021 - 23:01:07 EST


Hi Dmitry,

I love your patch! Yet something to improve:

[auto build test ERROR on pm/linux-next]
[also build test ERROR on tegra-drm/drm/tegra/for-next linus/master v5.14-rc7 next-20210826]
[cannot apply to tegra/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Dmitry-Osipenko/NVIDIA-Tegra-power-management-patches-for-5-16/20210827-093936
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: um-x86_64_defconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/11cffc90b58c476a1beca3ab35ff397d7363498d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Dmitry-Osipenko/NVIDIA-Tegra-power-management-patches-for-5-16/20210827-093936
git checkout 11cffc90b58c476a1beca3ab35ff397d7363498d
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=um SUBARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All error/warnings (new ones prefixed by >>):

In file included from <command-line>:
>> include/linux/compiler_types.h:149:16: error: expected '{' before 'inline'
149 | #define inline inline __gnu_inline __inline_maybe_unused notrace
| ^~~~~~
include/linux/pm_opp.h:438:15: note: in expansion of macro 'inline'
438 | static struct inline dev_pm_opp *dev_pm_opp_from_clk_rate(struct device *dev)
| ^~~~~~
>> include/linux/compiler_types.h:149:16: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
149 | #define inline inline __gnu_inline __inline_maybe_unused notrace
| ^~~~~~
include/linux/pm_opp.h:438:15: note: in expansion of macro 'inline'
438 | static struct inline dev_pm_opp *dev_pm_opp_from_clk_rate(struct device *dev)
| ^~~~~~


vim +149 include/linux/compiler_types.h

71391bdd2e9aab Xiaozhou Liu 2018-12-14 141
71391bdd2e9aab Xiaozhou Liu 2018-12-14 142 /*
71391bdd2e9aab Xiaozhou Liu 2018-12-14 143 * Prefer gnu_inline, so that extern inline functions do not emit an
71391bdd2e9aab Xiaozhou Liu 2018-12-14 144 * externally visible function. This makes extern inline behave as per gnu89
71391bdd2e9aab Xiaozhou Liu 2018-12-14 145 * semantics rather than c99. This prevents multiple symbol definition errors
71391bdd2e9aab Xiaozhou Liu 2018-12-14 146 * of extern inline functions at link time.
71391bdd2e9aab Xiaozhou Liu 2018-12-14 147 * A lot of inline functions can cause havoc with function tracing.
71391bdd2e9aab Xiaozhou Liu 2018-12-14 148 */
889b3c1245de48 Masahiro Yamada 2020-04-06 @149 #define inline inline __gnu_inline __inline_maybe_unused notrace
71391bdd2e9aab Xiaozhou Liu 2018-12-14 150

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip