[linux-stable-rc:linux-4.19.y 1159/1498] drivers/net/wireless/st/cw1200/txrx.c:627:27: warning: equality comparison with extraneous parentheses

From: kernel test robot
Date: Thu Aug 26 2021 - 17:22:40 EST

Next message: David Hildenbrand: "Re: [RFC] KVM: mm: fd-based approach for supporting KVM guest private memory"
Previous message: Sean Anderson: "[PATCH v6 3/3] pwm: Add support for Xilinx AXI Timer"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
head: 7457eed4b647560ae1b1800c295efc5f1db22e4b
commit: 7aaf09fd5c63ee9dc86325896abdfa47c54d39a9 [1159/1498] kbuild: support LLVM=1 to switch the default tools to Clang/LLVM
config: hexagon-randconfig-r014-20210826 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project ea08c4cd1c0869ec5024a8bb3f5cdf06ab03ae83)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=7aaf09fd5c63ee9dc86325896abdfa47c54d39a9
git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git fetch --no-tags linux-stable-rc linux-4.19.y
git checkout 7aaf09fd5c63ee9dc86325896abdfa47c54d39a9
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=hexagon

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/st/cw1200/txrx.c:627:27: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
else if ((wsm->queue_id == WSM_QUEUE_VOICE))
~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
drivers/net/wireless/st/cw1200/txrx.c:627:27: note: remove extraneous parentheses around the comparison to silence this warning
else if ((wsm->queue_id == WSM_QUEUE_VOICE))
~ ^ ~
drivers/net/wireless/st/cw1200/txrx.c:627:27: note: use '=' to turn this equality comparison into an assignment
else if ((wsm->queue_id == WSM_QUEUE_VOICE))
^~
=
drivers/net/wireless/st/cw1200/txrx.c:629:27: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
else if ((wsm->queue_id == WSM_QUEUE_VIDEO))
~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
drivers/net/wireless/st/cw1200/txrx.c:629:27: note: remove extraneous parentheses around the comparison to silence this warning
else if ((wsm->queue_id == WSM_QUEUE_VIDEO))
~ ^ ~
drivers/net/wireless/st/cw1200/txrx.c:629:27: note: use '=' to turn this equality comparison into an assignment
else if ((wsm->queue_id == WSM_QUEUE_VIDEO))
^~
=
2 warnings generated.
--
>> drivers/net/wireless/ti/wl18xx/main.c:1864:43: warning: unused variable 'wl18xx_iface_ap_cl_limits' [-Wunused-const-variable]
static const struct ieee80211_iface_limit wl18xx_iface_ap_cl_limits[] = {
^
>> drivers/net/wireless/ti/wl18xx/main.c:1883:43: warning: unused variable 'wl18xx_iface_ap_go_limits' [-Wunused-const-variable]
static const struct ieee80211_iface_limit wl18xx_iface_ap_go_limits[] = {
^
2 warnings generated.
--
>> drivers/net/wireless/ti/wl18xx/debugfs.c:76:1: warning: variable 'res' set but not used [-Wunused-but-set-variable]
WL18XX_DEBUGFS_FWSTATS_FILE_ARRAY(tx, tx_retry_per_rate,
^
drivers/net/wireless/ti/wl18xx/debugfs.c:38:2: note: expanded from macro 'WL18XX_DEBUGFS_FWSTATS_FILE_ARRAY'
DEBUGFS_FWSTATS_FILE_ARRAY(a, b, c, wl18xx_acx_statistics)
^
drivers/net/wireless/ti/wl18xx/../wlcore/debugfs.h:99:6: note: expanded from macro 'DEBUGFS_FWSTATS_FILE_ARRAY'
int res, i; \
^
drivers/net/wireless/ti/wl18xx/debugfs.c:127:1: warning: variable 'res' set but not used [-Wunused-but-set-variable]
WL18XX_DEBUGFS_FWSTATS_FILE_ARRAY(pwr, cont_miss_bcns_spread,
^
drivers/net/wireless/ti/wl18xx/debugfs.c:38:2: note: expanded from macro 'WL18XX_DEBUGFS_FWSTATS_FILE_ARRAY'
DEBUGFS_FWSTATS_FILE_ARRAY(a, b, c, wl18xx_acx_statistics)
^
drivers/net/wireless/ti/wl18xx/../wlcore/debugfs.h:99:6: note: expanded from macro 'DEBUGFS_FWSTATS_FILE_ARRAY'
int res, i; \
^
drivers/net/wireless/ti/wl18xx/debugfs.c:148:1: warning: variable 'res' set but not used [-Wunused-but-set-variable]
WL18XX_DEBUGFS_FWSTATS_FILE_ARRAY(rx_rate, rx_frames_per_rates, 50);
^
drivers/net/wireless/ti/wl18xx/debugfs.c:38:2: note: expanded from macro 'WL18XX_DEBUGFS_FWSTATS_FILE_ARRAY'
DEBUGFS_FWSTATS_FILE_ARRAY(a, b, c, wl18xx_acx_statistics)
^
drivers/net/wireless/ti/wl18xx/../wlcore/debugfs.h:99:6: note: expanded from macro 'DEBUGFS_FWSTATS_FILE_ARRAY'
int res, i; \
^
drivers/net/wireless/ti/wl18xx/debugfs.c:150:1: warning: variable 'res' set but not used [-Wunused-but-set-variable]
WL18XX_DEBUGFS_FWSTATS_FILE_ARRAY(aggr_size, tx_agg_rate,
^
drivers/net/wireless/ti/wl18xx/debugfs.c:38:2: note: expanded from macro 'WL18XX_DEBUGFS_FWSTATS_FILE_ARRAY'
DEBUGFS_FWSTATS_FILE_ARRAY(a, b, c, wl18xx_acx_statistics)
^
drivers/net/wireless/ti/wl18xx/../wlcore/debugfs.h:99:6: note: expanded from macro 'DEBUGFS_FWSTATS_FILE_ARRAY'
int res, i; \
^
drivers/net/wireless/ti/wl18xx/debugfs.c:152:1: warning: variable 'res' set but not used [-Wunused-but-set-variable]
WL18XX_DEBUGFS_FWSTATS_FILE_ARRAY(aggr_size, tx_agg_len,
^
drivers/net/wireless/ti/wl18xx/debugfs.c:38:2: note: expanded from macro 'WL18XX_DEBUGFS_FWSTATS_FILE_ARRAY'
DEBUGFS_FWSTATS_FILE_ARRAY(a, b, c, wl18xx_acx_statistics)
^
drivers/net/wireless/ti/wl18xx/../wlcore/debugfs.h:99:6: note: expanded from macro 'DEBUGFS_FWSTATS_FILE_ARRAY'
int res, i; \
^
drivers/net/wireless/ti/wl18xx/debugfs.c:154:1: warning: variable 'res' set but not used [-Wunused-but-set-variable]
WL18XX_DEBUGFS_FWSTATS_FILE_ARRAY(aggr_size, rx_size,
^
drivers/net/wireless/ti/wl18xx/debugfs.c:38:2: note: expanded from macro 'WL18XX_DEBUGFS_FWSTATS_FILE_ARRAY'
DEBUGFS_FWSTATS_FILE_ARRAY(a, b, c, wl18xx_acx_statistics)
^
drivers/net/wireless/ti/wl18xx/../wlcore/debugfs.h:99:6: note: expanded from macro 'DEBUGFS_FWSTATS_FILE_ARRAY'
int res, i; \
^
drivers/net/wireless/ti/wl18xx/debugfs.c:170:1: warning: variable 'res' set but not used [-Wunused-but-set-variable]
WL18XX_DEBUGFS_FWSTATS_FILE_ARRAY(pipeline, pipeline_fifo_full,
^
drivers/net/wireless/ti/wl18xx/debugfs.c:38:2: note: expanded from macro 'WL18XX_DEBUGFS_FWSTATS_FILE_ARRAY'
DEBUGFS_FWSTATS_FILE_ARRAY(a, b, c, wl18xx_acx_statistics)
^
drivers/net/wireless/ti/wl18xx/../wlcore/debugfs.h:99:6: note: expanded from macro 'DEBUGFS_FWSTATS_FILE_ARRAY'
int res, i; \
^
drivers/net/wireless/ti/wl18xx/debugfs.c:173:1: warning: variable 'res' set but not used [-Wunused-but-set-variable]
WL18XX_DEBUGFS_FWSTATS_FILE_ARRAY(diversity, num_of_packets_per_ant,
^
drivers/net/wireless/ti/wl18xx/debugfs.c:38:2: note: expanded from macro 'WL18XX_DEBUGFS_FWSTATS_FILE_ARRAY'
DEBUGFS_FWSTATS_FILE_ARRAY(a, b, c, wl18xx_acx_statistics)
^
drivers/net/wireless/ti/wl18xx/../wlcore/debugfs.h:99:6: note: expanded from macro 'DEBUGFS_FWSTATS_FILE_ARRAY'
int res, i; \
^
drivers/net/wireless/ti/wl18xx/debugfs.c:184:1: warning: variable 'res' set but not used [-Wunused-but-set-variable]
WL18XX_DEBUGFS_FWSTATS_FILE_ARRAY(calib, fail_count,
^
drivers/net/wireless/ti/wl18xx/debugfs.c:38:2: note: expanded from macro 'WL18XX_DEBUGFS_FWSTATS_FILE_ARRAY'
DEBUGFS_FWSTATS_FILE_ARRAY(a, b, c, wl18xx_acx_statistics)
^
drivers/net/wireless/ti/wl18xx/../wlcore/debugfs.h:99:6: note: expanded from macro 'DEBUGFS_FWSTATS_FILE_ARRAY'
int res, i; \
^
9 warnings generated.

Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for FRAME_POINTER
Depends on DEBUG_KERNEL && (M68K || UML || SUPERH) || ARCH_WANT_FRAME_POINTERS
Selected by
- LOCKDEP && DEBUG_KERNEL && LOCK_DEBUGGING_SUPPORT && !MIPS && !PPC && !ARM_UNWIND && !S390 && !MICROBLAZE && !ARC && !X86

vim +627 drivers/net/wireless/st/cw1200/txrx.c

a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 585
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 586 /* BT Coex specific handling */
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 587 static void
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 588 cw1200_tx_h_bt(struct cw1200_common *priv,
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 589 struct cw1200_txinfo *t,
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 590 struct wsm_tx *wsm)
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 591 {
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 592 u8 priority = 0;
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 593
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 594 if (!priv->bt_present)
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 595 return;
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 596
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 597 if (ieee80211_is_nullfunc(t->hdr->frame_control)) {
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 598 priority = WSM_EPTA_PRIORITY_MGT;
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 599 } else if (ieee80211_is_data(t->hdr->frame_control)) {
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 600 /* Skip LLC SNAP header (+6) */
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 601 u8 *payload = &t->skb->data[t->hdrlen];
7258416c517c79 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-06-20 602 __be16 *ethertype = (__be16 *)&payload[6];
7258416c517c79 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-06-20 603 if (be16_to_cpu(*ethertype) == ETH_P_PAE)
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 604 priority = WSM_EPTA_PRIORITY_EAPOL;
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 605 } else if (ieee80211_is_assoc_req(t->hdr->frame_control) ||
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 606 ieee80211_is_reassoc_req(t->hdr->frame_control)) {
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 607 struct ieee80211_mgmt *mgt_frame =
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 608 (struct ieee80211_mgmt *)t->hdr;
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 609
7258416c517c79 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-06-20 610 if (le16_to_cpu(mgt_frame->u.assoc_req.listen_interval) <
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 611 priv->listen_interval) {
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 612 pr_debug("Modified Listen Interval to %d from %d\n",
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 613 priv->listen_interval,
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 614 mgt_frame->u.assoc_req.listen_interval);
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 615 /* Replace listen interval derieved from
8b3e7be437a6b6 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-06-11 616 * the one read from SDD
8b3e7be437a6b6 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-06-11 617 */
7258416c517c79 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-06-20 618 mgt_frame->u.assoc_req.listen_interval = cpu_to_le16(priv->listen_interval);
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 619 }
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 620 }
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 621
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 622 if (!priority) {
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 623 if (ieee80211_is_action(t->hdr->frame_control))
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 624 priority = WSM_EPTA_PRIORITY_ACTION;
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 625 else if (ieee80211_is_mgmt(t->hdr->frame_control))
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 626 priority = WSM_EPTA_PRIORITY_MGT;
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 @627 else if ((wsm->queue_id == WSM_QUEUE_VOICE))
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 628 priority = WSM_EPTA_PRIORITY_VOICE;
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 629 else if ((wsm->queue_id == WSM_QUEUE_VIDEO))
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 630 priority = WSM_EPTA_PRIORITY_VIDEO;
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 631 else
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 632 priority = WSM_EPTA_PRIORITY_DATA;
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 633 }
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 634
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 635 pr_debug("[TX] EPTA priority %d.\n", priority);
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 636
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 637 wsm->flags |= priority << 1;
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 638 }
a910e4a94f6923 drivers/net/wireless/cw1200/txrx.c Solomon Peachy 2013-05-24 639

:::::: The code at line 627 was first introduced by commit
:::::: a910e4a94f6923c8c988565525f017f687bf7205 cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets

:::::: TO: Solomon Peachy <pizza@xxxxxxxxxxxx>
:::::: CC: John W. Linville <linville@xxxxxxxxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip

Next message: David Hildenbrand: "Re: [RFC] KVM: mm: fd-based approach for supporting KVM guest private memory"
Previous message: Sean Anderson: "[PATCH v6 3/3] pwm: Add support for Xilinx AXI Timer"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]