Re: [PATCH v3 1/2] x86/sgx: Add the missing ifdef for sgx_set_attribute()

[Borislav Petkov]

On Thu, Aug 26, 2021 at 08:31:13PM +0300, Jarkko Sakkinen wrote:
> The actual problem is to use it in set_memory.c.

So I asked you in the first mail:

"Please explain what exactly is this fixing."

> This the unsplit version:
> 
> https://lore.kernel.org/linux-sgx/20210818132509.545997-1-jarkko@xxxxxxxxxx/

But you're still feeding me some pieces of the puzzle piecemeal.

> Should I just squash them again into one patch?

You should explain *why* you're fixing whatever you're fixing and your
commit message should explain exactly how the bug is triggered so that
the reader of that commit message can reproduce it on their end.

Otherwise it'll get ignored until you do it right.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette