Re: [PATCH v3 1/2] x86/sgx: Add the missing ifdef for sgx_set_attribute()

From: Jarkko Sakkinen
Date: Thu Aug 26 2021 - 13:11:32 EST


On Thu, 2021-08-26 at 18:35 +0200, Borislav Petkov wrote:
> On Thu, Aug 26, 2021 at 07:08:07PM +0300, Jarkko Sakkinen wrote:
> > I made this change because I'm including the header to set_memory.c, and
>
> This is something you're doing locally, I presume. If so, you can keep
> this patch local too.
>
> > It's also incoherent that KVM specific functions are compilation flagged
>
> They don't really have to be - they're just declarations.

Let me check.

Is your preference is to have in set_memory.c:

#ifdef CONFIG_X86_SGX
#include <asm/sgx.h>
#endif

instead of doing this in uapi/asm/sgx.h?

/Jarkko