Re: [PATCH] perf tools: Fix *probe_vfs_getname.sh test failures

From: Arnaldo Carvalho de Melo
Date: Wed Aug 25 2021 - 13:10:05 EST


Em Wed, Aug 25, 2021 at 05:42:59PM +0100, James Clark escreveu:
> The commit 4d6101f5fd5d ("perf probe: Clarify error message about not
> finding kernel modules debuginfo") changed the error message "Failed to
> find the path for kernel" to "Failed to find the path for the kernel".
>
> Update the regex so that the tests still skip rather than fail when
> kernel debug symbols aren't present.

Thanks, applied.

- Arnaldo


> Signed-off-by: James Clark <james.clark@xxxxxxx>
> ---
> tools/perf/tests/shell/lib/probe_vfs_getname.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/shell/lib/probe_vfs_getname.sh b/tools/perf/tests/shell/lib/probe_vfs_getname.sh
> index c2cc42daf924..5b17d916c555 100644
> --- a/tools/perf/tests/shell/lib/probe_vfs_getname.sh
> +++ b/tools/perf/tests/shell/lib/probe_vfs_getname.sh
> @@ -19,6 +19,6 @@ add_probe_vfs_getname() {
> }
>
> skip_if_no_debuginfo() {
> - add_probe_vfs_getname -v 2>&1 | egrep -q "^(Failed to find the path for kernel|Debuginfo-analysis is not supported)" && return 2
> + add_probe_vfs_getname -v 2>&1 | egrep -q "^(Failed to find the path for the kernel|Debuginfo-analysis is not supported)" && return 2
> return 1
> }
> --
> 2.28.0

--

- Arnaldo