Re: sound/soc/sof/intel/hda-dai.c:265:22: warning: Value stored to 'sdev' during its initialization is never read [clang-analyzer-deadcode.DeadStores]

From: Pierre-Louis Bossart
Date: Tue Aug 24 2021 - 12:53:47 EST


Thanks for the report, I am not sure it's a real issue?
>>> sound/soc/sof/intel/hda-dai.c:265:22: warning: Value stored to 'sdev' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
> struct snd_sof_dev *sdev =
> ^~~~
> sound/soc/sof/intel/hda-dai.c:265:22: note: Value stored to 'sdev' during its initialization is never read
> struct snd_sof_dev *sdev =
> ^~~~
> fdd961e37e47f2 Keyon Jie 2019-04-12 259
> fdd961e37e47f2 Keyon Jie 2019-04-12 260 static int hda_link_pcm_prepare(struct snd_pcm_substream *substream,
> fdd961e37e47f2 Keyon Jie 2019-04-12 261 struct snd_soc_dai *dai)
> fdd961e37e47f2 Keyon Jie 2019-04-12 262 {
> ed3baacd76baa0 Ranjani Sridharan 2019-04-30 263 struct hdac_ext_stream *link_dev =
> ed3baacd76baa0 Ranjani Sridharan 2019-04-30 264 snd_soc_dai_get_dma_data(dai, substream);
> fdd961e37e47f2 Keyon Jie 2019-04-12 @265 struct snd_sof_dev *sdev =
> fdd961e37e47f2 Keyon Jie 2019-04-12 266 snd_soc_component_get_drvdata(dai->component);
> 1205300af9dba3 Kuninori Morimoto 2020-07-20 267 struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
> fdd961e37e47f2 Keyon Jie 2019-04-12 268 int stream = substream->stream;
> fdd961e37e47f2 Keyon Jie 2019-04-12 269
> a3ebccb52efdfb Kai Vehmanen 2019-07-22 270 if (link_dev->link_prepared)
> fdd961e37e47f2 Keyon Jie 2019-04-12 271 return 0;
> fdd961e37e47f2 Keyon Jie 2019-04-12 272
> ed3baacd76baa0 Ranjani Sridharan 2019-04-30 273 dev_dbg(sdev->dev, "hda: prepare stream dir %d\n", substream->stream);
> fdd961e37e47f2 Keyon Jie 2019-04-12 274
> fdd961e37e47f2 Keyon Jie 2019-04-12 275 return hda_link_hw_params(substream, &rtd->dpcm[stream].hw_params,
> fdd961e37e47f2 Keyon Jie 2019-04-12 276 dai);
> fdd961e37e47f2 Keyon Jie 2019-04-12 277 }
> fdd961e37e47f2 Keyon Jie 2019-04-12 278

The sdev variable is used in the dev_dbg() log, this looks legit to me?