Re: [PATCH] arm64: dts: qcom: db410c: Update firmware-name for wcnss and mpss

[Bjorn Andersson]

On Tue 24 Aug 05:39 PDT 2021, Dmitry Baryshkov wrote:

> On Thu, 18 Feb 2021 at 01:38, Aníbal Limón <anibal.limon@xxxxxxxxxx> wrote:
> >
> > From: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> >
> > Enable the mpss remoteproc node and specify the firmware-name for this
> > and the wcnss remoteproc on the Dragonboard 410c.
> >
> > Link: https://lore.kernel.org/r/20200108055735.660475-1-bjorn.andersson@xxxxxxxxxx
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> > [rebased and moved to use pronto label]
> > Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
> > Tested-by: Aníbal Limón <anibal.limon@xxxxxxxxxx>
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> 

Thanks Dmitry, not sure why this hasn't been merged yet.

Taking a further look at this I noticed that we never pushed the
firmware to linux-firmware either, which I think was because we where
uncertain of the directory structure at the time - a discussion which
has been settled since.

> > ---
> >  arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> > index 3c7f97539390..8f1ada75d3ed 100644
> > --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
> > @@ -301,6 +301,11 @@ &lpass {
> >         status = "okay";
> >  };
> >
> > +&mpss {
> > +       status = "okay";
> > +       firmware-name = "qcom/msm8916/mba.mbn", "qcom/msm8916/modem.mdt";

But if we're pushing things to linux-firmware, does anyone object
against following the existing style and squashing the mdt+bNN files
into .mbn (and thereby making this modem.mbn and below wcnss.mbn)?

Regards,
Bjorn

> > +};
> > +
> >  &pm8916_resin {
> >         status = "okay";
> >         linux,code = <KEY_VOLUMEDOWN>;
> > @@ -308,6 +313,7 @@ &pm8916_resin {
> >
> >  &pronto {
> >         status = "okay";
> > +       firmware-name = "qcom/msm8916/wcnss.mdt";
> >  };
> >
> >  &sdhc_1 {
> > --
> > 2.30.0
> >
> 
> 
> -- 
> With best wishes
> Dmitry