Re: [PATCH linux-next] kernel:fair: fix boolreturn.cocci warnings

From: Steven Rostedt
Date: Tue Aug 24 2021 - 09:41:41 EST


On Tue, 24 Aug 2021 10:22:49 +0200
Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> On Tue, Aug 24, 2021 at 10:15:54AM +0200, Peter Zijlstra wrote:
> > On Mon, Aug 23, 2021 at 11:23:59PM -0700, CGEL wrote:
> > > From: Jing Yangyang <jing.yangyang@xxxxxxxxxx>
> > >
> > > ./kernel/sched/fair.c:9638:9-10:WARNING: return of 0/1 in function
> > > 'imbalanced_active_balance' with return type bool
> > >
> > > Return statements in functions returning bool should use true/false
> > > instead of 1/0.
> > >
> > > Generated by: scripts/coccinelle/misc/boolreturn.cocci
> > >
> > > Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> > > Signed-off-by: Jing Yangyang <jing.yangyang@xxxxxxxxxx>
> >
> > *sigh*, another stupid robot sending stupid patches..
> >
> > /me goes create another mail filter...
>
> Here, the hunk of sieve script, incase other people want to use it too.
>
>
> #SCRIPTNAME: Zeal Robot
> if body :text :contains "Reported-by: Zeal Robot <zealci@xxxxxxxxxx>"
> {
> fileinto "SPAM";
> stop;
> }

Doesn't hurt to just take the patch and then you wont have to spend
time on new robots flagging this as a "bug".

-- Steve