Re: [PATCH] cpufreq: qcom-cpufreq-hw: Fix 'make allmodconfig' build

From: SeongJae Park
Date: Tue Aug 24 2021 - 05:14:41 EST


Hi,

On Sun, 22 Aug 2021 17:14:04 -0400 "Valdis Klētnieks" <valdis.kletnieks@xxxxxx> wrote:

>
> [-- Attachment #1: Type: text/plain, Size: 270 bytes --]
>
> On Sun, 22 Aug 2021 14:08:08 -0700, Randy Dunlap said:
>
> > This fixes one build error for me but I am still seeing another one:
> >
> > ERROR: modpost: "cpu_scale" [drivers/cpufreq/qcom-cpufreq-hw.ko] undefined!
>
> That's a different patch, am working on fixing that one now..

I didn't take a deep look here, so I unsure if this is an appropriate fix, but
I was able to work-around this issue for my use case with below change.

```
--- a/drivers/base/arch_topology.c
+++ b/drivers/base/arch_topology.c
@@ -149,6 +149,7 @@ void topology_set_freq_scale(const struct cpumask *cpus, unsigned long cur_freq,
}

DEFINE_PER_CPU(unsigned long, cpu_scale) = SCHED_CAPACITY_SCALE;
+EXPORT_PER_CPU_SYMBOL_GPL(cpu_scale);

void topology_set_cpu_scale(unsigned int cpu, unsigned long capacity)
{
```


Thanks,
SJ