Re: [PATCH 0/4] slimbus: patches (set 1) for 5.15

From: Greg KH
Date: Sat Aug 07 2021 - 10:16:55 EST


On Sat, Aug 07, 2021 at 02:26:11PM +0100, Srinivas Kandagatla wrote:
>
>
> On 07/08/2021 14:08, Greg KH wrote:
> > On Sat, Aug 07, 2021 at 02:04:39PM +0100, Srinivas Kandagatla wrote:
> > >
> > >
> > > On 07/08/2021 14:01, Greg KH wrote:
> > > > On Sat, Aug 07, 2021 at 11:48:48AM +0100, Srinivas Kandagatla wrote:
> > > > >
> > > > >
> > > > > On 06/08/2021 14:20, Greg KH wrote:
> > > > > > On Fri, Aug 06, 2021 at 10:16:35AM +0100, Srinivas Kandagatla wrote:
> > > > > > > Hi Greg,
> > > > > > >
> > > > > > > Recently runtime pm testing on slimbus reveled that its
> > > > > > > totally broken on SlimBus ngd drivers.
> > > > > > >
> > > > > > > Below are the fixes to get it back working.
> > > > > > >
> > > > > > > - One of the reason begin incorrect device pointer used for
> > > > > > > runtime pm and in some places
> > > > > > >
> > > > > > > - Second one was to do with unable to validate transaction id
> > > > > > > which resulted in negative runtime pm count.
> > > > > > >
> > > > > > > - Other fix was to do with resetting dma addresses once ngd
> > > > > > > controller is power-cycled.
> > > > > > >
> > > > > > > With all these fixed runtime pm is now fully functional on NGD
> > > > > > > controllers.
> > > > > > >
> > > > > > > Currently I marked them all with Cc: <stable@xxxxxxxxxxxxxxx>
> > > > > > > as these all patches are required to fix runtime pm on SlimBus
> > > > > > > NGD controller.
> > > > > > >
> > > > > > > Can you please queue them up for 5.15.
> > > > > >
> > > > > > Why do you want these for 5.15-rc1 when you need them to fix problems in
> > > > > > 5.14? Shouldn't they go into 5.14-final?
> > > > >
> > > > > Yes, these should go to other stable trees aswell.
> > > > > I assumed that Fixes tag will automatically backport those patches.
> > > >
> > > > Yes, but that can not happen until they hit Linus's tree, which would
> > > > not be until 5.15-rc1. Do you want to delay until that long from now?
> > > >
> > > > How about splitting this into 2 patch series, one that you want to see
> > > > get into 5.14-final, and one for 5.15-rc1.
> > >
> > > All the patches in these series are fixes so the can go to 5.14-final.
> >
> > Then why did you say originally that you wanted them in 5.15?
>
> TBH, I tend to send out SlimBus and nvmem patches only once around rc5-rc6
> time which also includes some minor fixes, and you normally apply them for
> next rc1 release.
>
> In this particular case I should have explicitly said to pick them up for
> 5.14 next rc.
>
> Do you want me to resend them with proper cover letter? or are you okay to
> take them as they are?

Yes, please resend the series, for some reason I didn't think the first
one needed to go to 5.14-final, but I might have been thinking of a
different patch series...

thanks,

greg k-h