Re: [PATCH net-next v2] ethernet/intel: fix PTP_1588_CLOCK dependencies

From: Richard Cochran
Date: Tue Aug 03 2021 - 12:16:17 EST


On Tue, Aug 03, 2021 at 08:55:56AM -0700, Richard Cochran wrote:
> On Tue, Aug 03, 2021 at 08:59:02AM +0200, Arnd Bergmann wrote:
> > It may well be a lost cause, but a build fix is not the time to nail down
> > that decision. The fix I proposed (with the added MAY_USE_PTP_1588_CLOCK
> > symbol) is only two extra lines and leaves everything else working for the
> > moment.
>
> Well, then we'll have TWO ugly and incomprehensible Kconfig hacks,
> imply and MAY_USE.
>
> Can't we fix this once and for all?
>
> Seriously, "imply" has been nothing but a major PITA since day one,
> and all to save 22 kb. I can't think of another subsystem which
> tolerates so much pain for so little gain.

Here is what I want to have, in accordance with the KISS principle:

config PTP_1588_CLOCK
bool "PTP clock support"
select NET
select POSIX_TIMERS
select PPS
select NET_PTP_CLASSIFY

# driver variant 1:

config ACME_MAC
select PTP_1588_CLOCK

# driver variant 2:

config ACME_MAC

config ACME_MAC_PTP
depends on ACME_MAC
select PTP_1588_CLOCK

Hm?

Thanks,
Richard