Re: [PATCH 13/38] hwmon: Replace deprecated CPU-hotplug functions.

From: Guenter Roeck
Date: Tue Aug 03 2021 - 11:30:07 EST


On Tue, Aug 03, 2021 at 04:15:56PM +0200, Sebastian Andrzej Siewior wrote:
> The functions get_online_cpus() and put_online_cpus() have been
> deprecated during the CPU hotplug rework. They map directly to
> cpus_read_lock() and cpus_read_unlock().
>
> Replace deprecated CPU-hotplug functions with the official version.
> The behavior remains unchanged.
>
> Cc: Jean Delvare <jdelvare@xxxxxxxx>
> Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> Cc: linux-hwmon@xxxxxxxxxxxxxxx
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>

Applied.

Thanks,
Guenter

> ---
> drivers/hwmon/dell-smm-hwmon.c | 4 ++--
> drivers/hwmon/fam15h_power.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index f2221ca0aa7be..c3600266e0e91 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -228,9 +228,9 @@ static int i8k_smm(struct smm_regs *regs)
> {
> int ret;
>
> - get_online_cpus();
> + cpus_read_lock();
> ret = smp_call_on_cpu(0, i8k_smm_func, regs, true);
> - put_online_cpus();
> + cpus_read_unlock();
>
> return ret;
> }
> diff --git a/drivers/hwmon/fam15h_power.c b/drivers/hwmon/fam15h_power.c
> index 29f5fed28c2a7..521534d5c1e5f 100644
> --- a/drivers/hwmon/fam15h_power.c
> +++ b/drivers/hwmon/fam15h_power.c
> @@ -166,7 +166,7 @@ static int read_registers(struct fam15h_power_data *data)
>
> memset(data->cu_on, 0, sizeof(int) * MAX_CUS);
>
> - get_online_cpus();
> + cpus_read_lock();
>
> /*
> * Choose the first online core of each compute unit, and then
> @@ -190,7 +190,7 @@ static int read_registers(struct fam15h_power_data *data)
>
> on_each_cpu_mask(mask, do_read_registers_on_cu, data, true);
>
> - put_online_cpus();
> + cpus_read_unlock();
> free_cpumask_var(mask);
>
> return 0;