Re: [PATCH v4 1/6] iommu: Refactor iommu_group_store_type()

From: Will Deacon
Date: Mon Aug 02 2021 - 10:46:32 EST


On Wed, Jul 14, 2021 at 06:36:38PM +0800, John Garry wrote:
> Function iommu_group_store_type() supports changing the default domain
> of an IOMMU group.
>
> Many conditions need to be satisfied and steps taken for this action to be
> successful.
>
> Satisfying these conditions and steps will be required for setting other
> IOMMU group attributes, so factor into a common part and a part specific
> to update the IOMMU group attribute.
>
> No functional change intended.
>
> Some code comments are tidied up also.
>
> Signed-off-by: John Garry <john.garry@xxxxxxxxxx>
> ---
> drivers/iommu/iommu.c | 73 +++++++++++++++++++++++++++----------------
> 1 file changed, 46 insertions(+), 27 deletions(-)

Acked-by: Will Deacon <will@xxxxxxxxxx>

Although likely to conflict with Robin's monster series.

Will