Re: [RFC net-next v2 4/4] Revert "mt7530 mt7530_fdb_write only set ivl bit vid larger than 1"

From: Vladimir Oltean
Date: Mon Aug 02 2021 - 09:44:20 EST


On Sun, Aug 01, 2021 at 03:10:22AM +0800, DENG Qingfang wrote:
> This reverts commit 7e777021780e9c373fc0c04d40b8407ce8c3b5d5.
>
> As independent VLAN learning is also used on VID 0 and 1, remove the
> special case.
>
> Signed-off-by: DENG Qingfang <dqfext@xxxxxxxxx>
> ---
> drivers/net/dsa/mt7530.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
> index 38d6ce37d692..d72e04011cc5 100644
> --- a/drivers/net/dsa/mt7530.c
> +++ b/drivers/net/dsa/mt7530.c
> @@ -366,8 +366,7 @@ mt7530_fdb_write(struct mt7530_priv *priv, u16 vid,
> int i;
>
> reg[1] |= vid & CVID_MASK;
> - if (vid > 1)
> - reg[1] |= ATA2_IVL;
> + reg[1] |= ATA2_IVL;
> reg[2] |= (aging & AGE_TIMER_MASK) << AGE_TIMER;
> reg[2] |= (port_mask & PORT_MAP_MASK) << PORT_MAP;
> /* STATIC_ENT indicate that entry is static wouldn't
> --
> 2.25.1
>

Would you mind explaining what made VID 1 special in Eric's patch in the
first place?