Re: [PATCH] KVM: const-ify all relevant uses of struct kvm_memory_slot

From: Hamza Mahfooz
Date: Fri Jul 30 2021 - 16:48:09 EST



Hey Peter,

On Fri, Jul 30 2021 at 04:19:21 PM -0400, Peter Xu <peterx@xxxxxxxxxx> wrote:
This patch breaks kvm/queue with above issue. Constify of kvm_memory_slot
pointer should have nothing to do with this so at least it should need a
separate patch. At the meantime I also don't understand why memcpy() here,
which seems to be even slower..

To const-ify the slot member of struct slot_rmap_walk_iterator, we need to
initialize a new struct and then copy it over (otherwise we would need to relay
on casting again or the compiler will complain about it).