Re: Re: [PATCH] kobject: kobject_add_internal cleanup

From: qiaoyanbo_310@xxxxxxx
Date: Fri Jul 30 2021 - 08:47:58 EST


On Fri, Jul 30, 2021 at 06:48:23AM +0200, Greg KH wrote:
> On Fri, Jul 30, 2021 at 12:44:26AM +0800, qiaoyanbo_310 wrote:
> > Hi Greg KH,
>
> Sorry, but html email is rejected by the mailing lists. Please try
> again after fixing up your email client, and I will be glad to respond.
>
> thanks,
>
> greg k-h

(Sorry, this is the first time I use the mutt environment to send mail,
shamed on me I know~)

>Why is this a problem? What bug is this solving? Is the code somehow
>now faster or smaller that can be measured?

I don't think the logic of the original code is self consistent.
This is not a bug, but it causes some unnecessary assignment operations.
This patch is to clean unnecessary assignment operations.

Thanks,
Qiao Yanbo