Re: [PATCH 1/2] memory: omap-gpmc: Clear GPMC_CS_CONFIG7 register on restore if unused

From: Roger Quadros
Date: Fri Jul 30 2021 - 06:59:56 EST




On 27/07/2021 13:10, Tony Lindgren wrote:
> We want to clear any unused GPMC_CS_CONFIG7 register on restore to
> ensure unused chip selects are not enabled.
>
> Cc: Roger Quadros <rogerq@xxxxxxxxxx>
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>

Acked-by: Roger Quadros <rogerq@xxxxxxxxxx>

Sorry if you got this twice. I got a bounce back on the previous Ack.

cheers,
-roger

> ---
> drivers/memory/omap-gpmc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
> --- a/drivers/memory/omap-gpmc.c
> +++ b/drivers/memory/omap-gpmc.c
> @@ -2595,6 +2595,8 @@ void omap3_gpmc_restore_context(void)
> gpmc_context.cs_context[i].config6);
> gpmc_cs_write_reg(i, GPMC_CS_CONFIG7,
> gpmc_context.cs_context[i].config7);
> + } else {
> + gpmc_cs_write_reg(i, GPMC_CS_CONFIG7, 0);
> }
> }
> }
>