Re: [PATCHv1 3/3] net: stmmac: dwmac-meson8b: Add reset controller for ethernet phy

From: Andrew Lunn
Date: Thu Jul 29 2021 - 16:21:11 EST


> @@ -465,6 +478,13 @@ static int meson8b_dwmac_probe(struct platform_device *pdev)
> goto err_remove_config_dt;
> }
>
> + dwmac->eth_reset = devm_reset_control_get_exclusive(dwmac->dev, "ethreset");
> + if (IS_ERR_OR_NULL(dwmac->eth_reset)) {
> + dev_err(dwmac->dev, "Failed to get Ethernet reset\n");
> + ret = PTR_ERR(dwmac->eth_reset);
> + goto err_remove_config_dt;
> + }
> +

Hi Anand

Since this is a new property, you need to handle it not being in the
DT blob. You probably need to use
devm_reset_control_get_optinal_exclusive()

Andrew