Re: New warning in nvme_setup_discard

[Ming Lei]

On Tue, Jul 27, 2021 at 05:12:03PM +0200, Oleksandr Natalenko wrote:
> Hello.
> 
> On středa 21. července 2021 10:00:56 CEST Ming Lei wrote:
> > > I'm still hammering v5.14-rc2 + your patch, and I cannot reproduce the
> > > issue. Given I do not have a reliable reproducer (I'm just firing up the
> > > kernel build, and the issue pops up eventually, sooner or later, but
> > > usually within a couple of first tries), for how long I should hammer it
> > > for your fix to be considered proven?
> > 
> > You mentioned that the issue is reproducible with v5.14-rc, that means
> > it can be always reproduced in limited time(suppose it is A). If the issue
> > can't be reproduced any more after applying the patch in long enough time
> > B(B >> A), we can think it is fixed by the patch.
> > 
> > For example, if A is one hour, we can set B as 5*A or bigger to simulate
> > the long enough time.
> 
> With your patch the issue is still not reproducible for me. Hence, from my 
> side the patch looks to be verified.

OK.

BTW, can you test the following patch? which is another approach on the same
issue with other benefits.