Re: [PATCH v3 2/2] hwrng: Add Arm SMCCC TRNG based driver

[Mark Brown]

On Mon, Jul 26, 2021 at 06:56:10PM +0100, Andre Przywara wrote:

> +static int smccc_trng_init(struct hwrng *rng)
> +{
> +	return 0;
> +}

If this can be empty (looking at the core it seems like it can) then
best just remove it.

> +	platform_set_drvdata(pdev, trng);
> +	ret = devm_hwrng_register(&pdev->dev, trng);
> +	if (!ret)
> +		dev_info(&pdev->dev,
> +			 "ARM SMCCC TRNG firmware random number generator\n");

Is the log message needed given that we're not announcing any version
information here or anything?  A brief sampling of other drivers
suggests it's not a standard thing for the subsystem.

Attachment: signature.asc
Description: PGP signature